Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automator: Update dependencies in istio-ecosystem/sail-operator@main #540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Automator: Update dependencies in istio-ecosystem/sail-operator@main #540

wants to merge 1 commit into from

Conversation

openshift-service-mesh-bot
Copy link
Collaborator

@openshift-service-mesh-bot openshift-service-mesh-bot commented Dec 20, 2024 •
edited
Loading

Generated by Automator - 2025-01-16T05:03:06+00:00

@openshift-service-mesh-bot openshift-service-mesh-bot requested a review from a team as a code owner December 20, 2024 05:05
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (ba24e34) to head (b5ac086).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files          40       40           
  Lines        2481     2481           
=======================================
  Hits         1871     1871           
  Misses        518      518           
  Partials       92       92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-service-mesh-bot openshift-service-mesh-bot force-pushed the none-main-update_deps-ae78d97e branch 8 times, most recently from 283f858 to a3e51d5 Compare December 28, 2024 05:05
@openshift-service-mesh-bot openshift-service-mesh-bot force-pushed the none-main-update_deps-ae78d97e branch 3 times, most recently from 5592679 to 5241b5d Compare December 31, 2024 05:05
@openshift-service-mesh-bot openshift-service-mesh-bot force-pushed the none-main-update_deps-ae78d97e branch 7 times, most recently from 10f65c4 to 481b937 Compare January 7, 2025 05:05
@dgn
Copy link
Collaborator

dgn commented Jan 7, 2025

/retest

@openshift-service-mesh-bot openshift-service-mesh-bot force-pushed the none-main-update_deps-ae78d97e branch 5 times, most recently from 94e676a to ae2c946 Compare January 12, 2025 05:05
@openshift-service-mesh-bot openshift-service-mesh-bot force-pushed the none-main-update_deps-ae78d97e branch 3 times, most recently from ccb65ef to be4a13d Compare January 15, 2025 05:05
@FilipB FilipB mentioned this pull request Jan 15, 2025
Closed
@dgn
Copy link
Collaborator

dgn commented Jan 16, 2025

The error is strange:

     2025-01-16T05:10:30Z	ERROR	ctrlr.istiorev	Reconciler error	{"IstioRevision": "default", "reconcileID": "8e8b0207-eeaf-4901-b6a2-bae21b3b52cc", "error": "failed to install/update Helm chart \"istiod\": failed to install helm chart istiod: 1 error occurred:\n\t* Service \"istiod\" is invalid: spec.ipFamilyPolicy: Invalid value: \"RequireDualStack\": this cluster is not configured for dual-stack services\n\n"}

Will retry but maybe @sridhargaddam can take a look?

/retest

@istio-testing
Copy link
Collaborator

@openshift-service-mesh-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_sail-operator_main b5ac086 link true /test lint
e2e-kind-dualstack_sail-operator_main b5ac086 link true /test e2e-kind-dualstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sridhargaddam
Copy link
Contributor

sridhargaddam commented Jan 16, 2025 •
edited
Loading

Will retry but maybe @sridhargaddam can take a look?

Recently there were some changes in upstream Istio where enableDualStack flag is removed and instead ipFamilies is introduced. Probably this could be some regression because of that change. I'll take a look.

@sridhargaddam sridhargaddam mentioned this pull request Jan 16, 2025
Closed
1 task
@sridhargaddam
Copy link
Contributor

The following PR should fix the issue: #559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-service-mesh-bot @dgn @istio-testing @sridhargaddam